From 0b7d6744bfd64b1c6be1131d3d68bd93fba2f9b2 Mon Sep 17 00:00:00 2001
From: benkuly <12199167+benkuly@users.noreply.github.com>
Date: Tue, 2 Jun 2020 08:39:30 +0200
Subject: [PATCH] added more docs and timeout value

---
 docs/configuring-playbook-matrix-sms-bridge.md              | 6 ++++++
 roles/matrix-sms-bridge/defaults/main.yml                   | 3 +++
 .../templates/systemd/matrix-sms-bridge.service.j2          | 2 +-
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/docs/configuring-playbook-matrix-sms-bridge.md b/docs/configuring-playbook-matrix-sms-bridge.md
index ef2aeb08..00aaecec 100644
--- a/docs/configuring-playbook-matrix-sms-bridge.md
+++ b/docs/configuring-playbook-matrix-sms-bridge.md
@@ -5,6 +5,8 @@ The playbook can install and configure
 
 See the project page to learn what it does and why it might be useful to you.
 
+First you need to ensure, that the bridge has unix read and write rights to your modem. On debian based distributions there is nothing to do. On others distributions you either add a group `dialout` to your host and assign it to your modem or you give the matrix user or group access to your modem.
+
 To enable the bridge just use the following
 playbook configuration:
 
@@ -16,6 +18,10 @@ matrix_sms_bridge_gammu_modem: "/path/to/modem"
 matrix_sms_bridge_database_password: ""
 # (optional) a room id to a default room
 matrix_sms_bridge_default_room: "" 
+# (optional) gammu reset frequency (see https://wammu.eu/docs/manual/smsd/config.html#option-ResetFrequency)
+matrix_sms_bridge_gammu_reset_frequency: 3600
+# (optional) group with unix read and write rights to modem
+matrix_sms_bridge_modem_group: 'dialout'
 ```
 
 
diff --git a/roles/matrix-sms-bridge/defaults/main.yml b/roles/matrix-sms-bridge/defaults/main.yml
index faf2b6fc..610b8f46 100644
--- a/roles/matrix-sms-bridge/defaults/main.yml
+++ b/roles/matrix-sms-bridge/defaults/main.yml
@@ -48,6 +48,8 @@ matrix_sms_bridge_homserver_domain: "{{ matrix_domain }}"
 matrix_sms_bridge_default_room: ''
 
 matrix_sms_bridge_gammu_modem: ''
+matrix_sms_bridge_modem_group: 'dialout'
+matrix_sms_bridge_gammu_reset_frequency: 0
 
 
 matrix_sms_bridge_configuration_yaml: |
@@ -122,6 +124,7 @@ matrix_sms_bridge_gammu_configuration: |
   InboxFormat = detail
   OutboxFormat = detail
   TransmitFormat = auto
+  ResetFrequency = {{ matrix_sms_bridge_gammu_reset_frequency }}
   debugLevel = 1
   LogFile = /data/log/smsd.log
   DeliveryReport = log
diff --git a/roles/matrix-sms-bridge/templates/systemd/matrix-sms-bridge.service.j2 b/roles/matrix-sms-bridge/templates/systemd/matrix-sms-bridge.service.j2
index 5c3b9544..cf8ab9fe 100644
--- a/roles/matrix-sms-bridge/templates/systemd/matrix-sms-bridge.service.j2
+++ b/roles/matrix-sms-bridge/templates/systemd/matrix-sms-bridge.service.j2
@@ -20,7 +20,7 @@ ExecStartPre=/bin/sleep 5
 ExecStart=/usr/bin/docker run --rm --name matrix-sms-bridge \
 			--log-driver=none \
 			--user={{ matrix_user_uid }}:{{ matrix_user_gid }} \
-			--group-add dialout \
+			--group-add {{ matrix_sms_bridge_modem_group }} \
 			--cap-drop=ALL \
 			--network={{ matrix_docker_network }} \
 			{% if matrix_sms_bridge_container_http_host_bind_port %}